namespace: support set namespace for meta #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolouch
reviewed
Nov 7, 2017
| c.Assert(tableClassifier.AddMetaToNamespace("test1"), IsNil) | ||
| // Can't be set again. | ||
| c.Assert(tableClassifier.AddMetaToNamespace("test1"), NotNil) | ||
| c.Assert(tableClassifier.AddMetaToNamespace("test2"), NotNil) |
There was a problem hiding this comment.
why we just allow one namespace to add meta?
There was a problem hiding this comment.
Same behavior as tables, a table or meta is only allow to bind to a namespace.
siddontang
reviewed
Nov 7, 2017
| return namespace.DefaultNamespace | ||
| } | ||
|
|
||
| for name, ns := range c.nsInfo.namespaces { | ||
| _, ok := ns.TableIDs[tableID] | ||
| if ok { | ||
| if ok || (isMeta && ns.Meta) { | ||
| return name |
There was a problem hiding this comment.
any test to cover meta here?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #824